refactor: move FocusOriginMonitor into CDK #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
devversion,
jelbourn,
josephperrott,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
|
While we're at it, I'd kind of like to rename it to just |
|
|
crisbeto
force-pushed
the
focus-origin-monitor-cdk
branch
2 times, most recently
from
a38bca6
to
c60d9e1
Compare
crisbeto
force-pushed
the
focus-origin-monitor-cdk
branch
from
c60d9e1
to
f64fa72
Compare
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Sep 11, 2017
crisbeto
added
the
P1
crisbeto
force-pushed
the
focus-origin-monitor-cdk
branch
2 times, most recently
from
1eb7aae
to
9375a4f
Compare
Moves the `FocusOriginMonitor` into `@angular/cdk/a11y`, renames it to `FocusMonitor`, deprecates the `StyleModule` and updates all the references. BREAKING CHANGE: `FocusOriginMonitor` has been renamed to `FocusMonitor`.
crisbeto
force-pushed
the
focus-origin-monitor-cdk
branch
from
9375a4f
to
14d40e1
Compare
|
@jelbourn you forgot to mention StyleModule is deprecated in release note. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
FocusOriginMonitorinto@angular/cdk/a11y, renames it toFocusMonitor, deprecates theStyleModuleand updates all the references.BREAKING CHANGE:
FocusOriginMonitorhas been renamed toFocusMonitor.